thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4072) Add the possibility to send custom headers in TCurlClient
Date Thu, 09 Feb 2017 20:04:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860097#comment-15860097
] 

ASF GitHub Bot commented on THRIFT-4072:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1178
  
    If the class has no testing at all then I would not require you to add tests in order
to get committed, however as Jens suggested it would improve the quality of the project if
tests were put in, so I always ask.
    
    It looks like you are making modifications in your master branch and they are getting
sync'd into this pull request.  In the future I would recommend that you create a branch off
master first, like "git checkout -b THRIFT-4072" and then submit a pull request from that
branch instead so it is isolated from the changes in your master.  There should only be one
commit for your changes... it looks like the way you have it set up, every time the apache
master is revised your pull request will rebuild here, which is a bit heavy.
    
    If the previous build was clean I can merge this.


> Add the possibility to send custom headers in TCurlClient
> ---------------------------------------------------------
>
>                 Key: THRIFT-4072
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4072
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.10.0
>            Reporter: Swati Kumar
>            Priority: Minor
>              Labels: patch
>
> Currently, there is no ability to add custom headers in TCurlClient.php which is the
PHP implementation of https://issues.apache.org/jira/browse/THRIFT-2394
> The THttpClient already supports it https://issues.apache.org/jira/browse/THRIFT-1878



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message