thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4072) Add the possibility to send custom headers in TCurlClient
Date Thu, 09 Feb 2017 19:44:42 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860067#comment-15860067
] 

ASF GitHub Bot commented on THRIFT-4072:
----------------------------------------

Github user swatkatz commented on the issue:

    https://github.com/apache/thrift/pull/1178
  
    @jeking3 : I can add the tests as you suggest, but since this is a minor feature improvement
and there don't seem to be any tests that exist for this class (and I see that other such
patches don't have them either e.g. https://github.com/apache/thrift/commit/1f9717d192137d06927846cc2f2f7e380e5da834),
I was just wondering what the standard practice around this was?


> Add the possibility to send custom headers in TCurlClient
> ---------------------------------------------------------
>
>                 Key: THRIFT-4072
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4072
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.10.0
>            Reporter: Swati Kumar
>            Priority: Minor
>              Labels: patch
>
> Currently, there is no ability to add custom headers in TCurlClient.php which is the
PHP implementation of https://issues.apache.org/jira/browse/THRIFT-2394
> The THttpClient already supports it https://issues.apache.org/jira/browse/THRIFT-1878



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message