thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4064) Update node library dependencies
Date Sat, 11 Feb 2017 01:44:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862140#comment-15862140
] 

ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1175
  
    I know very little about node.js in practice.  It would be up to other committers/members/contributors
who know node.js to weigh in on that.  My biggest concern is the hang in build job 8.  Can't
merge unless we get a clean CI run, and ideally a knowledgeable code review from someone else.
 I'm happy to help in any way I can otherwise to help make progress.


> Update node library dependencies
> --------------------------------
>
>                 Key: THRIFT-4064
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4064
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.10.0
>            Reporter: Andres Suarez
>            Assignee: James E. King, III
>
> ws@0.4.32 is really old and presents issues for users using modern versions of Node (see
https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message