thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4064) Update node library dependencies
Date Thu, 09 Feb 2017 19:56:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860083#comment-15860083
] 

ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1175
  
    I looked at the build results and in build job #2 it was still using node.js version 0.10
presumably because that's what is on the base install on the build slave being used:
    
    NodeJS Library:
       Using NodeJS .............. : /usr/bin/nodejs
       Using NodeJS version....... : v0.10.29
    
    The build failure has led me to a number of questions about how we maintain our docker
images, who is responsible for that, and how we stage changes like this so CI builds can pass
and prove the changes and new docker image are okay.  I have sent emails out to others on
the development team to learn this process and see if it needs to be modified to handle this
type of change.


> Update node library dependencies
> --------------------------------
>
>                 Key: THRIFT-4064
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4064
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.10.0
>            Reporter: Andres Suarez
>            Assignee: James E. King, III
>
> ws@0.4.32 is really old and presents issues for users using modern versions of Node (see
https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message