thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen George (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-2945) Implement support for Rust language
Date Wed, 15 Feb 2017 13:14:41 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867808#comment-15867808
] 

Allen George commented on THRIFT-2945:
--------------------------------------

Extracting {{write_from...}} and {{read_from...}}: Ok. Your points make sense. Please name
the new trait {{TSerializable}} then.

Doubles: Hmm, so you ran everything outlined in the [README|https://github.com/apache/thrift/blob/master/lib/rs/README.md]?
A minimal test type would be:

{noformat}
struct SomeStruct {
  1: double bare_double
  2: map<double, double> mapped_doubles
  3: set<double> set_of_doubles
}
{noformat}

Ah. Looks like it was an oversight on my part (I think?) I notice that there is a {{Hash}}
implementation for ordered float. This is ideal because I can replace the {{BTree...}} versions
of maps and sets with hashes if they work. That said, I only want to do that if it's an "all
or nothing" move; I want to avoid flags in code generation.

Namespaces: Can you confirm that all the steps in the README work? I would also update the
service inheritance [test|https://github.com/apache/thrift/tree/master/lib/rs/test] to ensure
that two identically named types can be referred to properly. For example:

{noformat}
Base_One.thrift: Define a struct "Foo"
Ultimate.thrift: Define another struct "Foo"; create a service call that uses Base_One.Foo
and Ultimate.Foo
{noformat}

> Implement support for Rust language
> -----------------------------------
>
>                 Key: THRIFT-2945
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2945
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Rust - Compiler, Rust - Library
>            Reporter: Maksim Golov
>            Assignee: Allen George
>             Fix For: 0.11.0
>
>
> Work on implementing support for Rust is in progress: https://github.com/maximg/thrift
by Simon GĂ©nier and myself.
> It will probably take quite some time to complete. Please keep us updated if there are
changes related to our work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message