thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apocolipse <...@git.apache.org>
Subject [GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library
Date Tue, 28 Feb 2017 20:02:46 GMT
Github user apocolipse commented on the issue:

    https://github.com/apache/thrift/pull/1084
  
    Update 2/28/2017:
    Old Swift generator and new merged into one,
    Old generator under `cocoa` option, `promise_kit` option only available for old generator
as well.
    
    I don't have any Swift 2.x projects so i can't really test, but if anyone else wants to
spot check code and test against old versions that'd be great.  I've left the old swift generator
CC file in tact (moved to `*.cc..old`), and spaced out things such that it lines up with the
new code line for line for comparison.
    
    Next and last steps to make this production ready IMO is namespacing, I'm going to add
an option to namespace by splitting into subdirectories.  Actually configuring projects will
be left up to the developer.  I'll add some output describing how to do it in SPM, but injecting
the targets into SPM or Xcodeproj are beyond the scope of Thrift so for now the only thing
namespacing will do is place source files in their own namespace relative directory, generate
imports when necessary, and appropriately namespace types.  Any suggestions or input are welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message