thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...
Date Sun, 19 Feb 2017 05:04:27 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1197#discussion_r101909034
  
    --- Diff: lib/py/src/transport/sslcompat.py ---
    @@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname):
     
    --- End diff --
    
    In the Ubuntu 14.04 LTS docker image, Python is version 2.7.6.  This means it doesn't
have SSLContext.  This code detects that condition and sets a single version that it can use.
 I am actually going to change the default to TLSv1.2 for security purposes here.  Any language
that cannot properly modify the openssl options to negotiate TLSv1.0 "or higher" should be
forced to TLSv1.2.  From what I can tell, csharp, d, and py2 (in the build image) lack the
necessary code/knowledge to allow for a SSLv23 handshake and then autonegotiate TLSv1.0 "or
higher".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message