thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nsuke <...@git.apache.org>
Subject [GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...
Date Sun, 19 Feb 2017 03:33:40 GMT
Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1197#discussion_r101907113
  
    --- Diff: test/tests.json ---
    @@ -606,5 +606,23 @@
           "compact"
         ],
         "workdir": "rs/bin"
    +  },
    +  {
    +    "name": "secure",
    +    "client": {
    +      "command": [
    +        "test_secure.bash"
    +      ]
    +    },
    +    "transports": [
    +      "buffered"
    +    ],
    +    "sockets": [
    +      "ip-ssl"
    +    ],
    +    "protocols": [
    +      "binary"
    +    ],
    +    "workdir": "secure"
    --- End diff --
    
    What do you think about moving them to test/features/tests.json ? Since it's not really
a language binding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message