thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] thrift pull request #1186: THRIFT-1805 Provide option for handling RTEs
Date Mon, 13 Feb 2017 18:33:51 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1186#discussion_r100861533
  
    --- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
    @@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
         "    android_legacy:  Do not use java.io.IOException(throwable) (available for Android
2.3 and "
         "above).\n"
         "    option_type:     Wrap optional fields in an Option type.\n"
    +    "    handle_runtime_exceptions:\n"
    +    "                     Generated services will handle RuntimeException as "
    --- End diff --
    
    I think the following documentation gives users a little more insight into what this option
does.  Is there a length limit?  I was trying to make the following short. 
    ```
    Adjust how server handles RuntimeException (RE). Default is to close connection on RE.
This enables sending TApplicationException on RE.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message