thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gadLinux <...@git.apache.org>
Subject [GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib
Date Fri, 10 Feb 2017 09:47:47 GMT
Github user gadLinux commented on the issue:

    https://github.com/apache/thrift/pull/1185
  
    Hi Jeking3, 
    Yes there's only the client at this time. Cause I had no time to implement server. The
tests can be run against Java or any other server. I will add after this commit is approved.
    
    The tests I added are rather limited because the lack of c_glib server. So yes I will
add them at latter step.
    
    About cross checks. It's the first time I see about it. In fact all tests I did where
against Java so they are naturally cross language. Again this should be added at a latter
step. I need the client to be "in" the next release cause lot of effort has been set securing
it. So the patch is big enough to split it in different issues.
    
    We can discuss later about a common library between C++ and c_glib, more testing, server
and many other improvements. But I think it's a good idea to have this in now that's running.
In our case is in production. Tested daily against hundreds of clients. And it's working fine.
    
    Can you merge it as is, please?
    
    And prepare after in the maillist the next features.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message