Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3DBF200BFB for ; Wed, 11 Jan 2017 16:46:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F2C51160B4E; Wed, 11 Jan 2017 15:46:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4AD79160B2E for ; Wed, 11 Jan 2017 16:46:59 +0100 (CET) Received: (qmail 80180 invoked by uid 500); 11 Jan 2017 15:46:58 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 80169 invoked by uid 99); 11 Jan 2017 15:46:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jan 2017 15:46:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5C4BD2C03DF for ; Wed, 11 Jan 2017 15:46:58 +0000 (UTC) Date: Wed, 11 Jan 2017 15:46:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 11 Jan 2017 15:47:00 -0000 [ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818667#comment-15818667 ] ASF GitHub Bot commented on THRIFT-3873: ---------------------------------------- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1128 There was just one issue on linux; I reverted a change in TBufferTransports.h (I had converted an assert to an exception, but we can figure out what to do with asserts holistically in THRIFT-3978). Hopefully this will pass. I have built this on all flavors of Visual Studio 2010, 2012, 2013, 2015 in Debug and Release, Win32 and x64, and run the unit tests. I also built this on Ubuntu 14.04. The CI build will prove out any other issues. > Fix various compiler warnings when using VS2010 > ----------------------------------------------- > > Key: THRIFT-3873 > URL: https://issues.apache.org/jira/browse/THRIFT-3873 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.10.0 > Environment: VS2010, Windows > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Minor > > While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up. As part of cleaning these up, I found that additional compilers were also posting warnings. > Acceptance Criteria: > # I can build successfully with Visual Studio 2010 targeting x86 debug mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2010 targeting x86 release mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2010 targeting x64 debug mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2010 targeting x64 release mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x86 debug mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x86 release mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x64 debug mode with /WX (warnings are errors). > # I can build successfully with Visual Studio 2015 targeting x64 release mode with /WX (warnings are errors). -- This message was sent by Atlassian JIRA (v6.3.4#6332)