Return-Path: <dev-return-43478-archive-asf-public=cust-asf.ponee.io@thrift.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 68851200BF1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue,  3 Jan 2017 23:16:05 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 672D5160B43; Tue,  3 Jan 2017 22:16:05 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id AD96F160B20
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  3 Jan 2017 23:16:04 +0100 (CET)
Received: (qmail 56246 invoked by uid 500); 3 Jan 2017 22:15:58 -0000
Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@thrift.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@thrift.apache.org>
List-Post: <mailto:dev@thrift.apache.org>
List-Id: <dev.thrift.apache.org>
Reply-To: dev@thrift.apache.org
Delivered-To: mailing list dev@thrift.apache.org
Received: (qmail 55993 invoked by uid 99); 3 Jan 2017 22:15:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 22:15:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id A3DE02C2A66
	for <dev@thrift.apache.org>; Tue,  3 Jan 2017 22:15:58 +0000 (UTC)
Date: Tue, 3 Jan 2017 22:15:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.12987832.1467994158000.632992.1483481758669@Atlassian.JIRA>
In-Reply-To: <JIRA.12987832.1467994158000@Atlassian.JIRA>
References: <JIRA.12987832.1467994158000@Atlassian.JIRA> <JIRA.12987832.1467994158215@arcas>
Subject: [jira] [Commented] (THRIFT-3873) Fix various compiler warnings when
 using VS2010
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Tue, 03 Jan 2017 22:16:05 -0000


    [ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796365#comment-15796365 ] 

ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1128#discussion_r94495800
  
    --- Diff: compiler/cpp/src/thrift/generate/t_erl_generator.cc ---
    @@ -984,10 +988,13 @@ void t_erl_generator::export_types_string(string name, int num) {
     }
     
     void t_erl_generator::export_function(t_function* tfunction, string prefix) {
    -
    +  t_struct::members_type::size_type num = tfunction->get_arglist()->get_members().size();
    +  if (num > std::numeric_limits<int>().max()) {
    --- End diff --
    
    Yes, I just finished a suite of batch files to build zlib, openssl, libevent, and thrift for VS 2010 through 2015, win32/x64, debug/release.  I started running into these signed/unsigned issues today and I am working through resolving it.  The acceptance criteria for this issue is that I can build all combinations with zero warnings - we'll see how close I get.


> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
>                 Key: THRIFT-3873
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3873
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>         Environment: VS2010, Windows
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Minor
>
> While verifying a defect I had to build the windows thrift C++ library and found a number of compiler warnings that needed to be cleaned up.  As part of cleaning these up, I found that additional compilers were also posting warnings.
> Acceptance Criteria:
> # I can build successfully with Visual Studio 2010 targeting x86 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x86 release mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2010 targeting x64 release mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x86 release mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 debug mode with /WX (warnings are errors).
> # I can build successfully with Visual Studio 2015 targeting x64 release mode with /WX (warnings are errors).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)