thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RobberPhex <>
Subject [GitHub] thrift pull request #1161: Thrift-4034 CMake doesn't work to build compiler
Date Thu, 19 Jan 2017 09:01:36 GMT
GitHub user RobberPhex opened a pull request:

    Thrift-4034 CMake doesn't work to build compiler


You can merge this pull request into a Git repository by running:

    $ git pull THRIFT-4034

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1161
commit cdd3a209a082bc05c9891f81d82e09095f0934fb
Author: Robert Lu <>
Date:   2017-01-19T03:40:53Z

    add cmake minimum version

commit 3dfae805b8901dc76be72b754767f45182ed3795
Author: Robert Lu <>
Date:   2017-01-19T03:42:15Z

    remove hack for rename header file

commit 3e7df74491bffa76ea5f0cc59135315b76e3367a
Author: Robert Lu <>
Date:   2017-01-19T04:23:50Z

    fix link error and BIN_INSTALL_DIR error

commit 0175e59a88b6e6ffa7b6b66d826e8b317030c5dd
Author: Robert Lu <>
Date:   2017-01-19T05:05:44Z

    thrift-compiler dir in cmake-build
    * because thrift dir in cmake-build, thrift target cannot make
    * thrifty.h include thrift/parse/t_program.h, solve struct dependency

commit 64b242ed6b0570c548868518572ac6baaf42f4a8
Author: Robert Lu <>
Date:   2017-01-19T05:19:58Z

    improve doc


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message