thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dcelasun <...@git.apache.org>
Subject [GitHub] thrift pull request #1156: THRIFT-4011 Use slices for Thrift sets
Date Sun, 15 Jan 2017 10:05:33 GMT
GitHub user dcelasun opened a pull request:

    https://github.com/apache/thrift/pull/1156

    THRIFT-4011 Use slices for Thrift sets

    As discussed in [THRIFT-4011](https://issues.apache.org/jira/browse/THRIFT-4011), this
commit changes the Go generator to use slices, instead of maps for Thrift sets.
    
    I've specifically didn't touch the Go library since there was no agreement on panicking
for duplicates. We have three options:
    
    1. Leave it as is and add documentation stating deduplication is the caller's responsibility.
    2. Silently deduplicate before serialization.
    3. panic on duplicates.
    
    2 and 3 probably requires [`reflect.DeepEqual`](https://golang.org/pkg/reflect/#DeepEqual),
which is not ideal.
    
    @Jens-G Thoughts?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dcelasun/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1156
    
----
commit 0e2e8c0b041300dafff641e19848a1e46df32bc6
Author: D. Can Celasun <dcelasun@gmail.com>
Date:   2017-01-15T09:53:19Z

    THRIFT-4011 Use slices for Thrift sets
    
    This commit changes the Go generator to use slices, instead of maps for Thrift sets.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message