thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler
Date Thu, 19 Jan 2017 15:01:26 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830067#comment-15830067
] 

ASF GitHub Bot commented on THRIFT-4034:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1161#discussion_r96876704
  
    --- Diff: compiler/cpp/CMakeLists.txt ---
    @@ -101,9 +102,6 @@ THRIFT_ADD_COMPILER(xml     "Enable compiler for XML" ON)
     # we also add the current binary directory for generated files
     include_directories(${CMAKE_CURRENT_BINARY_DIR} src)
     
    -if(NOT ${WITH_PLUGIN})
    --- End diff --
    
    This will break the thrift compiler plug-in module support.


> CMake doesn't work to build compiler
> ------------------------------------
>
>                 Key: THRIFT-4034
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4034
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>    Affects Versions: 0.10.0
>         Environment: macOS Sierra + CMake 3.7.2
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>              Labels: beginner
>             Fix For: 0.11.0
>
>
> AS [document|https://github.com/apache/thrift/blob/0.10.0/compiler/cpp/README.md#build-compiler-using-cmake]
said.
> When I ran {{cmake ..}} in {{/thrift/compiler/cpp/cmake-build}}, CMake reports error
as below:
> {quote}
> -- The C compiler identification is AppleClang 8.0.0.8000042
> -- The CXX compiler identification is AppleClang 8.0.0.8000042
> -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Found FLEX: /usr/bin/flex (found version "2.5.35") 
> -- Found BISON: /usr/local/bin/bison (found version "3.0.4") 
> CMake Error at CMakeLists.txt:152 (install):
>   install TARGETS given no RUNTIME DESTINATION for executable target
>   "thrift-compiler".
> CMake Warning (dev) in CMakeLists.txt:
>   No cmake_minimum_required command is present.  A line of code such as
>     cmake_minimum_required(VERSION 3.7)
>   should be added at the top of the file.  The version specified may be lower
>   if you wish to support older CMake versions for this project.  For more
>   information run "cmake --help-policy CMP0000".
> This warning is for project developers.  Use -Wno-dev to suppress it.
> -- Configuring incomplete, errors occurred!
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message