thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9
Date Sat, 28 Jan 2017 19:01:24 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15844159#comment-15844159
] 

ASF GitHub Bot commented on THRIFT-4026:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1166#discussion_r98337162
  
    --- Diff: build/docker/centos6/Dockerfile ---
    @@ -41,7 +41,9 @@ RUN yum install -y epel-release && \
         && yum clean all
     
     # optional dependencies
    -RUN pip install ipaddress backports.ssl_match_hostname tornado
    +# skipping ipaddress and backports.ssl_match_hostname to test legacy callback
    +# RUN pip install ipaddress backports.ssl_match_hostname tornado
    +RUN pip install tornado
    --- End diff --
    
    Does the ubuntu docker build need to be modified to match?


> TSSLSocket doesn't work with Python < 2.7.9
> -------------------------------------------
>
>                 Key: THRIFT-4026
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4026
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.10.0
>         Environment: Python 2.7.5
>            Reporter: Benoit Sigoure
>            Assignee: Aki Sukegawa
>            Priority: Critical
>
> As a result of a change made in THRIFT-3917, {{TSSLSocket}} now fails with a {{TypeError}}
in {{open()}}:
> {code}
>   File "/bld/thrift/Artools-rpmbuild/thrift-0.10.0/lib/py/build/lib.linux-i686-2.7/thrift/transport/TSSLSocket.py",
line 293, in open
>     self._validate_callback(self.peercert, self._server_hostname)
> TypeError: legacy_validate_callback() takes exactly 3 arguments (2 given)
> {code}
> Indeed, {{legacy_validate_callback()}} takes an extra {{self}} argument, which cannot
possibly be compatible with the signature of [{{ssl.match_hostname()}}|https://docs.python.org/3/library/ssl.html#ssl.match_hostname]
(which was added in Python 3.2).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message