thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with c_glib
Date Thu, 26 Jan 2017 14:31:24 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839748#comment-15839748
] 

ASF GitHub Bot commented on THRIFT-3369:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/930#discussion_r98003634
  
    --- Diff: lib/c_glib/test/CMakeLists.txt ---
    @@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND testoptionalrequired)
     
     include_directories("${PROJECT_SOURCE_DIR}/test/c_glib/src" "${CMAKE_CURRENT_BINARY_DIR}/gen-c_glib")
     
    -add_executable(testthrifttest testthrifttest.c
    --- End diff --
    
    Why was the testthrifttest executable removed?


> Implement SSL/TLS support on C with c_glib
> ------------------------------------------
>
>                 Key: THRIFT-3369
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3369
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C glib - Library
>    Affects Versions: 0.9.1, 0.9.2, 0.9.3, 1.0
>            Reporter: Gonzalo Aguilar
>              Labels: features, patch
>
> Implement SSL/TLS based on plain openssl instead of going through the way defined in
THRIFT-1016. 
> This help us to maintain a reference implementation and later switch over GIO or whatever
is defined. But also does not add any other dependencies to the project. So bare minimum installation
for supporting SSL/TLS is there and aligned with CPP counterpart. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message