thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Gould (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3013) make thrift compiler accept a list of input files
Date Sat, 21 Jan 2017 03:17:26 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832772#comment-15832772
] 

Benjamin Gould commented on THRIFT-3013:
----------------------------------------

FWIW I use the technique of creating a single file that contains only includes, and use the
-recurse option to make sure they are all processed, as Jens mentioned in a comment above.
 For the most part this works flawlessly... however IIRC in at least one language (PHP I think?)
this can cause an invalid file or two (Types.php IIRC) to be generated, but I think that problem
would occur in any namespace that does not define any structs or other types.  In any case,
I suppose it would be convenient to apply this feature to the compiler but just wanted to
point out that Jen's solution is a simple workaround.

Also FWIW I actually appreciate how simple it is to build the compiler... for the most part
I use Thrift with Java, JS, and PHP, and never with C++ so it is really nice to be able to
build with a simple ./configure --disable-libs && make && cp compiler/cpp/thrift
and not have to worry about boost, especially since the Thrift release cycle seems pretty
long and I don't even when releases happen I don't actually know where I would get binaries
other than for Windows... just my opinion of course

> make thrift compiler accept a list of input files
> -------------------------------------------------
>
>                 Key: THRIFT-3013
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3013
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (General)
>    Affects Versions: 0.9.2
>            Reporter: Xiaoshuang LU
>            Assignee: Roger Meier
>         Attachments: THRIFT-3013.v4.patch
>
>
> At present, customers could only specify one input file to thrift compiler.  There are
maybe two approaches to support multiple input files.
> Approach 1: Improve the option parser in compiler/cpp/src/main.cc.  Maybe we can borrow
code from GUN's getopt_long.
> Approach 2: Offer users a maven plugin which can help them to iterate through a list
of input files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message