thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King, III (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3013) make thrift compiler accept a list of input files
Date Fri, 20 Jan 2017 20:30:27 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832356#comment-15832356
] 

James E. King, III commented on THRIFT-3013:
--------------------------------------------

My preference would still be to use something like boost::program_options because there's
a high likelihood it will be part of C++ standard in the future.  The compiler is written
in C++.  Folks can obtain a binary thrift compiler from enough places today that I don't see
the need to dumb down the build experience of it.  You already have to go out and get WinFlexBison
on Windows and do a bit of work to know how to reference it in the cmake build of the compiler.
 When using boost to build the compiler, you can link it statically so the resulting binary
is portable.

My personal style is to leverage existing libraries, like boost, when they do a good job solving
a particular problem and leave the responsibility for that third party module in the hands
of the third party.  If a security issue is discovered in the getopt implementation that was
ingested, we become responsible for maintaining it.  

>From what Jake said, it sounds like it is okay to include a third party code module with
a different license from Apache's.  So if the majority of folks are leaning towards including
the getopt code in the compiler then so be it, I will back that.    Regardless of that, we
should all decide and move forward with the functionality.

> make thrift compiler accept a list of input files
> -------------------------------------------------
>
>                 Key: THRIFT-3013
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3013
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (General)
>    Affects Versions: 0.9.2
>            Reporter: Xiaoshuang LU
>            Assignee: Roger Meier
>         Attachments: THRIFT-3013.v4.patch
>
>
> At present, customers could only specify one input file to thrift compiler.  There are
maybe two approaches to support multiple input files.
> Approach 1: Improve the option parser in compiler/cpp/src/main.cc.  Maybe we can borrow
code from GUN's getopt_long.
> Approach 2: Offer users a maven plugin which can help them to iterate through a list
of input files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message