thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gadLinux <...@git.apache.org>
Subject [GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...
Date Thu, 26 Jan 2017 16:30:33 GMT
Github user gadLinux commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/930#discussion_r98028242
  
    --- Diff: lib/c_glib/test/Makefile.am ---
    @@ -37,16 +37,17 @@ BUILT_SOURCES = \
             gen-c_glib/t_test_thrift_test_types.h
     
     AM_CPPFLAGS = -I../src -I./gen-c_glib
    -AM_CFLAGS = -g -Wall -Wextra -pedantic $(GLIB_CFLAGS) $(GOBJECT_CFLAGS) \
    +AM_CFLAGS = -g -Wall -Wextra -pedantic $(GLIB_CFLAGS) $(GOBJECT_CFLAGS) $(OPENSSL_INCLUDES)
\
     	@GCOV_CFLAGS@
     AM_CXXFLAGS = $(AM_CFLAGS)
    -AM_LDFLAGS = $(GLIB_LIBS) $(GOBJECT_LIBS) @GCOV_LDFLAGS@
    +AM_LDFLAGS = $(GLIB_LIBS) $(GOBJECT_LIBS) $(OPENSSL_LIBS) @GCOV_LDFLAGS@
     
     check_PROGRAMS = \
       testserialization \
       testapplicationexception \
       testcontainertest \
       testtransportsocket \
    +  testtransportsslsocket \
    --- End diff --
    
    I think so. But since I don't have yet detection code for ssl there's no opt-out code.
I think it will not work without the openssl library. So we have to choices. Require OpenSSL
as you recommended above. Or make the code conditional, something is not ready yet. What do
you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message