thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...
Date Wed, 25 Jan 2017 14:30:52 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1080#discussion_r97789162
  
    --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
    @@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
       }
     
       // sets a flag so that the loop exits on the next event
    -  event_base_loopbreak(eventBase_);
    +  event_base_loopexit(eventBase_, 0);
    --- End diff --
    
    Your commends correspond to the discussion in the Jira entry for this item from @nsuke.
 Is that something you would have time to do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message