thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jens-G <...@git.apache.org>
Subject [GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...
Date Sat, 14 Jan 2017 09:58:36 GMT
Github user Jens-G commented on the issue:

    https://github.com/apache/thrift/pull/1088
  
    The first thing I noticed is that there are a bunch of one-line changes where an UTF-8
BOM has been added to certain files. Not that I'm against it, but can we at least have it
consistently? E.g. TSocketClientTransport.cs has a BOM, but TBufferedClientTransport.cs has
not. Minor issue only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message