thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift issue #1128: THRIFT-3873: fix compiler warnings on windows with VS201...
Date Wed, 11 Jan 2017 15:46:43 GMT
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1128
  
    There was just one issue on linux; I reverted a change in TBufferTransports.h (I had converted
an assert to an exception, but we can figure out what to do with asserts holistically in THRIFT-3978).
 Hopefully this will pass.  I have built this on all flavors of Visual Studio 2010, 2012,
2013, 2015 in Debug and Release, Win32 and x64, and run the unit tests.  I also built this
on Ubuntu 14.04.  The CI build will prove out any other issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message