thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1128: THRIFT-3873: fix compiler warnings on windows wit...
Date Wed, 11 Jan 2017 15:42:54 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1128#discussion_r95604407
  
    --- Diff: lib/cpp/src/thrift/windows/config.h ---
    @@ -36,6 +36,9 @@
     #define USE_BOOST_THREAD 1
     #endif
     
    +// Something that defines PRId64 is required to build
    +#define HAVE_INTTYPES_H 1
    +
    --- End diff --
    
    Note I have opened THRIFT-4025 because I don't see why we have a custom config.h file
on Windows when we go through the hassle of generating one with cmake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message