thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allengeorge <>
Subject [GitHub] thrift pull request #1147: THRIFT-2945 Add Rust support
Date Tue, 03 Jan 2017 02:07:10 GMT
Github user allengeorge commented on a diff in the pull request:
    --- Diff: test/ThriftTest.thrift ---
    @@ -67,7 +67,7 @@ typedef i64 UserId
     struct Bonk
       1: string message,
    -  2: i32 type
    +  2: i32 bonkType
    --- End diff --
    @Jens-G I'm sorry if my comment came across as rude. I'll change the code generator to
prefix reserved names with an identifier.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message