Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
MIME-Version: 1.0
In-Reply-To: <CAMcsLhJLLiviw-zUdeN89eLDFoMLzMP2x1TtWvmEAXFqhNt_hw@mail.gmail.com>
References: <CAMcsLhKdUZAANhu7urjKMys8FnDbsm+SgJQRmtSNRBg5-kGh0w@mail.gmail.com>
 <AM4PR0801MB15240C13843E113E20658417B1850@AM4PR0801MB1524.eurprd08.prod.outlook.com>
 <CAMcsLhJLLiviw-zUdeN89eLDFoMLzMP2x1TtWvmEAXFqhNt_hw@mail.gmail.com>
From: Allen George <allen.george@gmail.com>
Date: Wed, 7 Dec 2016 22:48:43 -0500
Message-ID: <CAMcsLhKp=oowMZiF+GT2DrqHs3dChFdAork5iNNRW_9zoEo+bw@mail.gmail.com>
Subject: Re: Why are there no unions in ThriftTest.thrift?
To: dev@thrift.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 08 Dec 2016 03:48:50 -0000

Ooops. My bad - "Jens" not "Jen". So sorry for the misspelling :(
Terminal Musings: http://www.allengeorge.com/
Raft in Java: https://github.com/allengeorge/libraft/
Twitter: https://twitter.com/allenageorge/


On Wed, Dec 7, 2016 at 10:48 PM, Allen George <allen.george@gmail.com> wrot=
e:
> Hi Jen,
>
> Ah. That makes sense. Absolutely - I'd be happy to toss up a PR in the
> next few days.
>
> Allen
> Terminal Musings: http://www.allengeorge.com/
> Raft in Java: https://github.com/allengeorge/libraft/
> Twitter: https://twitter.com/allenageorge/
>
>
> On Wed, Dec 7, 2016 at 3:09 AM, Jens Geyer <jensgeyer@hotmail.com> wrote:
>> Hi George,
>>
>> good question. Main reason is very likely because a) they were added lat=
er
>> and b) they work a lot like structs.
>>
>> Nevertheless you are absolutely right, they should be, as they are a cor=
e
>> part of the language. Would you mind adding them and some test cases in =
one
>> or two languages of your choice? That would be awesome. Having that, we =
can
>> start integrating those test cases in all other languages.
>>
>> @Aki, Jake & Roger: That will very likely break the Test suite until all
>> languages are properly covered. How can we handle this? Feature branch
>> maybe?
>>
>> Have fun,
>> JensG
>>
>>
>> -----Urspr=C3=BCngliche Nachricht-----
>> From: Allen George
>> Sent: Wednesday, December 7, 2016 12:09 AM
>> To: dev@thrift.apache.org
>> Subject: Why are there no unions in ThriftTest.thrift?
>>
>> It seems like a lot of other cases are covered, and unions seem like a
>> surprising omission. Why is that? I also notice that includes (and so,
>> namespaced-types) are not there as well.
>>
>> Thanks,
>> Allen
>>