Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Wed, 7 Nov 2012 16:03:12 +0000 (UTC)
From: "Bud Bundy (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <370489719.80953.1352304192590.JavaMail.jiratomcat@arcas>
Subject: [jira] [Created] (THRIFT-1748) Guard and RWGuard macros defined in
 global namespace
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Bud Bundy created THRIFT-1748:
---------------------------------

             Summary: Guard and RWGuard macros defined in global namespace
                 Key: THRIFT-1748
                 URL: https://issues.apache.org/jira/browse/THRIFT-1748
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 0.9
         Environment: Visual Studio 2010
            Reporter: Bud Bundy
            Priority: Trivial


thrift/concurrency/Mutex.h defines global macros Guard and RWGuard.  Although the purpose is well commented and appreciated - i.e. trying to prevent coders from creating temporary variables and falsely assuming they have a lock - this code does interfere with other packages that define their own Guard classes.  Even when the user/library define Guard in their own namespace, there's a clash.

Please remove the macros.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira