Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Mon, 12 Nov 2012 19:33:13 +0000 (UTC)
From: "Ben Craig (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <1347371713.102208.1352748793775.JavaMail.jiratomcat@arcas>
In-Reply-To: <471396744.93641.1352493792782.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (THRIFT-1750) Make compiler build cleanly under
 visual studio 10
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/THRIFT-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495538#comment-13495538 ] 

Ben Craig commented on THRIFT-1750:
-----------------------------------

MINGW still defines _WIN32, so that part seems to be fine.  My patch does have one MINGW issue though.  Windows uses "MAX_PATH", while *nix usis "PATH_MAX".  MINGW takes the *nix approach.  I will post an updated patch to address this, after I get an in-house review.

My new patch will be tested against contrib/mingw-cross-compiler.sh before submission.
                
> Make compiler build cleanly under visual studio 10
> --------------------------------------------------
>
>                 Key: THRIFT-1750
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1750
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>    Affects Versions: 0.9, 1.0
>         Environment: Windows, MSVC10
>            Reporter: Ben Craig
>             Fix For: 1.0
>
>         Attachments: compiler_cleanup.patch
>
>
> Building the thrift compiler in Visual Studio 10 causes a lot of warnings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira