Return-Path: 
 <dev-return-16294-apmail-thrift-dev-archive=thrift.apache.org@thrift.apache.org>
X-Original-To: apmail-thrift-dev-archive@www.apache.org
Delivered-To: apmail-thrift-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C0FF0D99D
	for <apmail-thrift-dev-archive@www.apache.org>;
 Fri, 16 Nov 2012 00:39:11 +0000 (UTC)
Received: (qmail 81698 invoked by uid 500); 16 Nov 2012 00:39:11 -0000
Delivered-To: apmail-thrift-dev-archive@thrift.apache.org
Received: (qmail 81659 invoked by uid 500); 16 Nov 2012 00:39:11 -0000
Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@thrift.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@thrift.apache.org>
List-Post: <mailto:dev@thrift.apache.org>
List-Id: <dev.thrift.apache.org>
Reply-To: dev@thrift.apache.org
Delivered-To: mailing list dev@thrift.apache.org
Received: (qmail 81646 invoked by uid 99); 16 Nov 2012 00:39:11 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Nov 2012 00:39:11 +0000
Date: Fri, 16 Nov 2012 00:39:11 +0000 (UTC)
From: "Roger Meier (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <1138691030.121771.1353026351394.JavaMail.jiratomcat@arcas>
In-Reply-To: <500495815.24502.1351116372492.JavaMail.jiratomcat@arcas>
Subject: [jira] [Resolved] (THRIFT-1740) Make C++ library build on OS X and
 iOS
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1740.
---------------------------------

    Resolution: Fixed
      Assignee: Ben Craig

Thanks Craig!
removed THRIFT_UNUSED_VARIABLE from the patch and committed.
-roger
                
> Make C++ library build on OS X and iOS
> --------------------------------------
>
>                 Key: THRIFT-1740
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1740
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9, 1.0
>         Environment: Patch fixes OS X xcode 3.2 with gcc 4.2 toolchain.  Also fixes iOS xcode 4.4 with clang 4.0 toolchain.
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>              Labels: c++, ios, mac
>             Fix For: 1.0, 0.9
>
>         Attachments: mac_and_ios.patch
>
>
> Various small issues keep the existing Thrift c++ libraries from building on OS X and iOS.  For example, in Clang, there is no <tr1/functional>, only a regular <functional>.  Instead of adding a new configure token and a million #ifdefs, the patch has added a wrapper header that throws the relevant <functional> symbols into the apache::thrift:stdcxx namespace.
> There are also several fixes for unused variable warnings in release mode.  I have added a helper macro to better document these cases (as opposed to just adding the mysterious "ret=ret;" everywhere).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira