thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer (JIRA)" <>
Subject [jira] [Commented] (THRIFT-1727) Ruby-1.9: data loss: "binary" fields are re-encoded
Date Mon, 12 Nov 2012 23:59:12 GMT


Nathan Beyer commented on THRIFT-1727:

{quote}This is not precisely the same as enforcing that "binary" fields get only BINARY encoded
strings and "string" fields get only non-BINARY encoded strings, but this is due to the peculiarity
of the Thrift specification that there is compatibility between these two types of strings
at the Thrift specification level. But because there is compatibility between these two types
of strings at the Ruby level, it actually fits quite nicely.{quote}

This approach would only work when sending data via the Ruby code, not when receiving data
via the Ruby code. For example, a Ruby client invocation of a service that returns 'binary'
data wouldn't be able to use this check as all of the Ruby String would be BINARY/ASCII-8BIT,
so all Thrift strings that are received via the Ruby code would have to attempt to decode
the bytes as UTF-8, per the type specification.

I think the only valid short-term approach is to try and get the field information into the
protocols. Strategically, I think 'binary' needs to be elevated to a base type. There could
be some intermediate approaches, such as creating a ByteBuffer type that can be passed around
in the generated code and then the protocol classes could use that as an indicator of the
'binary' type. I assume this is what happens in other libraries, like Java.
> Ruby-1.9: data loss: "binary" fields are re-encoded
> ---------------------------------------------------
>                 Key: THRIFT-1727
>                 URL:
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9
>         Environment: JRuby 1.6.8 using "--1.9" command line parameter.
>            Reporter: XB
> When setting a binary field of a Thrift object with some binary data (e.g. a string whose
encoding is "ASCII-8BIT") and then serializing this object, the binary data is re-encoded.
That is, it is encoded as if it were not a sequence of bytes but a sequence of characters,
encoded using the ISO-8859-1 encoding. This assumed ISO-8859-1 sequence of characters is then
converted into UTF-8 (by BinaryProtocol or CompactProtocol). This basically means that all
bytes whose values are between 0x80 (inclusive) and 0x100 (exclusive) are converted into multi-byte
sequences. This leads to data corruption.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message