thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bud Bundy (JIRA)" <>
Subject [jira] [Created] (THRIFT-1748) Guard and RWGuard macros defined in global namespace
Date Wed, 07 Nov 2012 16:03:12 GMT
Bud Bundy created THRIFT-1748:

             Summary: Guard and RWGuard macros defined in global namespace
                 Key: THRIFT-1748
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 0.9
         Environment: Visual Studio 2010
            Reporter: Bud Bundy
            Priority: Trivial

thrift/concurrency/Mutex.h defines global macros Guard and RWGuard.  Although the purpose
is well commented and appreciated - i.e. trying to prevent coders from creating temporary
variables and falsely assuming they have a lock - this code does interfere with other packages
that define their own Guard classes.  Even when the user/library define Guard in their own
namespace, there's a clash.

Please remove the macros.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message