thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Meier (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-1740) Make C++ library build on OS X and iOS
Date Fri, 16 Nov 2012 00:39:11 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Roger Meier resolved THRIFT-1740.
---------------------------------

    Resolution: Fixed
      Assignee: Ben Craig

Thanks Craig!
removed THRIFT_UNUSED_VARIABLE from the patch and committed.
-roger
                
> Make C++ library build on OS X and iOS
> --------------------------------------
>
>                 Key: THRIFT-1740
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1740
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9, 1.0
>         Environment: Patch fixes OS X xcode 3.2 with gcc 4.2 toolchain.  Also fixes iOS
xcode 4.4 with clang 4.0 toolchain.
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>              Labels: c++, ios, mac
>             Fix For: 1.0, 0.9
>
>         Attachments: mac_and_ios.patch
>
>
> Various small issues keep the existing Thrift c++ libraries from building on OS X and
iOS.  For example, in Clang, there is no <tr1/functional>, only a regular <functional>.
 Instead of adding a new configure token and a million #ifdefs, the patch has added a wrapper
header that throws the relevant <functional> symbols into the apache::thrift:stdcxx
namespace.
> There are also several fixes for unused variable warnings in release mode.  I have added
a helper macro to better document these cases (as opposed to just adding the mysterious "ret=ret;"
everywhere).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message