thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roger Meier (Resolved) (JIRA)" <>
Subject [jira] [Resolved] (THRIFT-1512) Thrift socket support for Windows XP
Date Mon, 06 Feb 2012 20:47:03 GMT


Roger Meier resolved THRIFT-1512.

    Resolution: Fixed
      Assignee: Peace C

Thanks Peace!
committed with little edits (2 spaces instead of tabs).
> Thrift socket support for Windows XP
> ------------------------------------
>                 Key: THRIFT-1512
>                 URL:
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.8
>         Environment: Windows XP, Visual Studio
>            Reporter: Peace C
>            Assignee: Peace C
>              Labels: msvc, thrift,, windows, xp
>             Fix For: 0.9
>         Attachments: Thrift_XP_skt_UNIXEOL.patch
> This is a follow-up patch to THRIFT-1490. The previous code would never follow the Windows
XP path (WINVER 0x0501). At least that appears to be the case since poll_win32() was incomplete
and not functional. Windows' version of select() does not set the revents field so FD_ISSET
is used to determine how to manually set it.  I've tested this on a sample project and it's
working as expected. config.h is now targeting XP for wider compatibility. If this isn't desired
or you don't trust the new code, comment out the two #define lines toward the top and it will
revert to targeting Vista/Win7.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message