thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Watson (Created) (JIRA)" <>
Subject [jira] [Created] (THRIFT-1445) minor C++ generator variable cleanup
Date Thu, 01 Dec 2011 23:48:40 GMT
minor C++ generator variable cleanup


                 Key: THRIFT-1445
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Library
            Reporter: Dave Watson
            Priority: Minor
         Attachments: 0004-thrift-minor-C-generator-variable-cleanup.patch

>From 5d5a0a42e5a20c9fc72d686c880614f6568a992e Mon Sep 17 00:00:00 2001
From: Adam Simpkins <>
Date: Mon, 14 Jun 2010 19:52:15 +0000
Subject: [PATCH 04/56] minor C++ generator variable cleanup

In generate_process_function(), service_func_name is always used as a
string literal.  Therefore, construct it with the double quotes
built-in, rather than having to add them everywhere we use it.

Test Plan:
Built [two internal fb projects]

DiffCamp Revision: 122187
Reviewed By: dreiss
CC: dreiss, kholst, thrift-team@lists
Revert Plan:

git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@29905 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
 compiler/cpp/src/generate/ |   90 +++++++++++++-------------
 1 files changed, 45 insertions(+), 45 deletions(-)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message