thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-1444) FunctionRunner - add syntactic sugar to create shared_ptrs
Date Tue, 06 Dec 2011 02:17:40 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163278#comment-13163278
] 

Hudson commented on THRIFT-1444:
--------------------------------

Integrated in Thrift #348 (See [https://builds.apache.org/job/Thrift/348/])
    Thrift-1444:FunctionRunner - add syntactic sugar to create shared_ptrs
Client: cpp
Patch: Dave Watson

Simplify FunctionRunner addTask calls.

                
> FunctionRunner - add syntactic sugar to create shared_ptrs

> -----------------------------------------------------------
>
>                 Key: THRIFT-1444
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1444
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: 0003-Thrift-FunctionRunner-add-syntactic-sugar-to-create-.patch
>
>
> From e1a2d69c5e178675e40aee3f01dadfebf11ca07b Mon Sep 17 00:00:00 2001
> From: Mark Rabkin <mrabkin@fb.com>
> Date: Fri, 11 Jun 2010 21:44:13 +0000
> Subject: [PATCH 03/56] FunctionRunner - add syntactic sugar to create shared_ptrs
> Summary:
> For FunctionRunner, you used to have to do a really awkward and
> verbose looking thing like:
>    (...)->addTask(boost::shared_ptr<FunctionRunner>(new FunctionRunner(
>       ... args ... )));
> Now you can do:
>    (...)->addTask(FunctionRunner::create( ... args ... ));
> Reviewers: simpkins,dreiss
> CC: thrift-team@lists.facebook.com
> Test Plan: ran concurrency test

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message