thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0
Date Fri, 20 May 2011 02:11:47 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036628#comment-13036628
] 

Carl Steinbach commented on THRIFT-1031:
----------------------------------------

This patch depends on pthreads_win32 library which carries an LGPL license. The [ASF License
FAQ|http://www.apache.org/legal/resolved.html#category-a] lists the LGPL in the prohibited
category, though it's unclear to me if this prohibition is limited to creating a derivative
work from LGPL'd code, or if it also applies to runtime dependencies against standalone LGPL
libraries. Does anyone know the answer?

> Patch to compile Thrift for vc++ 9.0 and 10.0
> ---------------------------------------------
>
>                 Key: THRIFT-1031
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1031
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>         Environment: Windows XP 32bit, vc++ 9.0, 10.0
>            Reporter: James Dickson
>            Priority: Trivial
>             Fix For: 0.7
>
>         Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch
>
>
> At our company we need clients running on Windows being able to connect to our linux
servers running hypertable. The attached patch enables the parts needed by Hypertable to be
compiled on Windows using either the VC++ 9.0 or 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be too intrusive
for our needs. This version uses pthreads_win32 and winsock2 and is as designed to be as un-intrusive
as is possible to the original unix code base. It is mostly #defines between unix sockets
and winsock2 sockets. We also tried to follow the folder structuring of the C# runtime that
has visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original unix code
base is available to windows users. We will add the missing functionality, we just wanted
to share what we had as for a Windows based client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and any code
reviews. If there is any possibility of this being added to the main trunk then that would
be much appreciated, however we don't expect that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message