thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Reiss (JIRA)" <j...@apache.org>
Subject [jira] Commented: (THRIFT-770) Get 'make dist' to work without first compiling source code
Date Tue, 04 May 2010 05:53:16 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863680#action_12863680
] 

David Reiss commented on THRIFT-770:
------------------------------------

One thing that I don't like about this commit is that there are two completely separate changes
in it, and the most important one wasn't in the description at all.  I think we should revert
this, recommit the "nodist" part of the patch with a better description, and try to figure
out a way of preserving the old version description (which is pretty useful when following
trunk) without causing problems for "make dist".  Thoughts?

> Get 'make dist' to work without first compiling source code
> -----------------------------------------------------------
>
>                 Key: THRIFT-770
>                 URL: https://issues.apache.org/jira/browse/THRIFT-770
>             Project: Thrift
>          Issue Type: Improvement
>    Affects Versions: 0.3
>            Reporter: Anthony Molinaro
>            Assignee: Anthony Molinaro
>             Fix For: 0.4
>
>         Attachments: dist.patch, version.h.in
>
>
> On current 0.3.0 tag (http://svn.apache.org/repos/asf/incubator/thrift/tags/0.3.0/) its
impossible to run
> % svn co http://svn.apache.org/repos/asf/incubator/thrift/tags/0.3.0/
> % ./bootstrap.sh && ./configure && make dist
> and get a working distribution.
> In order to fix this the use of the revision control systems revision must be dropped,
and instead the version must solely exist in the configure.ac.  This seems like a reasonable
thing, as the version in trunk is kept at the next release anyway.  The version.h file is
then created via configure.
> The attached patch can be applied against the tag above (although THRIFT-650 is required
for make check to work), as well as trunk.
> You also should svn remove print_version.sh and add the attached version.h.in into compiler/cpp.
> I've tested like
> % svn co http://svn.apache.org/repos/asf/incubator/thrift/tags/0.3.0/
> % patch -p0 < ~/dist.patch
> % patch -p0 < ~/check.patch  # THRIFT-650 patch
> % cp ~/version.h.in compiler/cpp
> % rm print_version.sh
> % ./bootstrap.sh && ./configure && make dist
> % tar xvfz thrift-0.3.0.tar.gz
> % cd thrift-0.3.0
> % ./configure && make && make check
> For testing against trunk it's the same thing without the THRIFT-650 patch (as that's
been recently applied, thanks Bryan!).
> My test machine is a Centos 5 vmware instance, so slightly older autoconf.  I would also
test on my Mac, but somehow gcc didn't make it past the user migration, so I need to wait
until I get the xcode disk at my office tomorrow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message