thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Walsh (JIRA)" <>
Subject [jira] Created: (THRIFT-525) ThriftTest project will not generate c# from .thrift file or generate ThriftImpl.dll
Date Tue, 23 Jun 2009 16:20:07 GMT
ThriftTest project will not generate c# from .thrift file or generate ThriftImpl.dll

                 Key: THRIFT-525
             Project: Thrift
          Issue Type: Bug
          Components: Library (C#), Test Suite
    Affects Versions: 0.2
         Environment: Windows, Visual 2008, x86, cygwin dependant thrift.exe compiler
            Reporter: Michael Walsh

The C# Library Solution (thrift\lib\csharp\src\Thrift.sln) fails to compile because of problems
with the PreBuildEvent for the ThriftTest Project (thrift\test\csharp\ThriftTest\ThriftTest.csproj).

- Thrift.exe is called with the outdated -csharp instead of --gen csharp
- All of the existing commands in the PreBuildEvent will fail if there's a space in any directory
name in the directory tree (such as "My Documents" or "Visual Studio 2008").
- The recursive forced rmdir command will match other directory trees that share a common
root (e.g. c:\test\Work\ will be recursively removed if the project is located in c:\test\Work
for Thrift\test\csharp)

I have attached a patch that replaces the PreBuildEvent in the ThriftTest project file to
fix these problems and work with directory trees that contain spaces.

As the thrift.exe compiler does NOT accept paths with spaces when surrounded by quotes, my
script generates MSDOS 8.3 pathnames to pass to the thrift compiler and it appears to work
just fine.

This has only been tested on my machine with pro 2008 and a current thrift checkout

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message