thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Stockton (JIRA)" <j...@apache.org>
Subject [jira] Updated: (THRIFT-276) Ruby libraries should have one class per file
Date Wed, 01 Apr 2009 20:51:13 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Stockton updated THRIFT-276:
------------------------------------

    Attachment: thrift-276-v3.patch

v3 patch will work with commits made by Bryan in THRIFT-417.

> Ruby libraries should have one class per file
> ---------------------------------------------
>
>                 Key: THRIFT-276
>                 URL: https://issues.apache.org/jira/browse/THRIFT-276
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>    Affects Versions: 0.1
>            Reporter: Bryan Duxbury
>            Assignee: Michael Stockton
>            Priority: Trivial
>         Attachments: thrift-276-v2.patch, thrift-276-v3.patch, thrift-276.patch
>
>
> There's no reason for so many of our classes to be lumped into the same file. For instance,
transport.rb contains 9 classes. They may be short, but organizationally, it's superior to
have separate class files. Of course, some files may contain more than one class per file
as appropriate - things like a protocol and its factory, for instance, are perfectly acceptable
to group.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message