thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Shigin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (THRIFT-265) Buffer bloat in TNonblockingServer
Date Wed, 04 Mar 2009 14:23:56 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678742#action_12678742
] 

Alexander Shigin commented on THRIFT-265:
-----------------------------------------

Look good to me, but I prefer to make 512 to a tunable parameter.

> Buffer bloat in TNonblockingServer
> ----------------------------------
>
>                 Key: THRIFT-265
>                 URL: https://issues.apache.org/jira/browse/THRIFT-265
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (C++)
>            Reporter: Erik Frey
>            Assignee: Erik Frey
>            Priority: Minor
>         Attachments: buffer_reset.patch, buffer_reset_v2.patch, graph.png
>
>
> TNonBlockingServer never resets the lengths of the buffers it maintains for reading and
writing.  Servers with a long life and many concurrent connections eventually generate an
overhead that can reach into the gigabytes, particularly in services that have varied message
sizes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message