thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Stockton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (THRIFT-254) Add optional strict version support to binary protocols
Date Thu, 05 Feb 2009 03:31:59 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670615#action_12670615
] 

Michael Stockton commented on THRIFT-254:
-----------------------------------------

Ok, I see what you're getting at.  Sorry, I was moving quickly and looked at writeMessageBegin
for an indication of version support (usually above readMessage) and I mistook your question
as to whether a library does not support both styles. 

> Add optional strict version support to binary protocols
> -------------------------------------------------------
>
>                 Key: THRIFT-254
>                 URL: https://issues.apache.org/jira/browse/THRIFT-254
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>            Reporter: Michael Stockton
>            Priority: Minor
>             Fix For: 0.1
>
>         Attachments: thrift-254-v2.patch, thrift-254-v3.patch, thrift-254.patch
>
>
> Several thrift libraries do not read a thrift version number in messages by default.
 This can cause issues for a ruby user who interacts with thrift services written in other
languages because the ruby library doesn't support an option to disable version validation.
> This patch does not change the default behavior, where thrift version numbers are expected,
but it does add the option to disable version validation.
> For example:
> Thrift::BinaryProtocol.new(transport, strict_read=false, strict_write=true)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message