thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Duxbury (JIRA)" <j...@apache.org>
Subject [jira] Commented: (THRIFT-81) TNonblockingServer should have the option to limit the number of clients or the amount of memory it will allocate to incomplete client frames
Date Thu, 20 Nov 2008 20:20:44 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649466#action_12649466
] 

Bryan Duxbury commented on THRIFT-81:
-------------------------------------

We've been using the v2 of this patch in production for a while now, and it seems to perform
quite well. Can a committer take a look so we can get this into the official codebase?

> TNonblockingServer should have the option to limit the number of clients or the amount
of memory it will allocate to incomplete client frames
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-81
>                 URL: https://issues.apache.org/jira/browse/THRIFT-81
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Trivial
>         Attachments: thrift-81-v2.patch, thrift-81.patch
>
>
> In the current TNonblockingServer implementation, it would be possible for a large number
of clients to connect to the server and send a very large 4-byte frame size, causing the server
to allocate lots of memory and die. The server should have an option to protect itself against
either overwhelming numbers of clients or more than a specified amount of memory at a time,
or both. This would make it much more robust in the face of an unknown pool of clients.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message