From issues-return-43570-archive-asf-public=cust-asf.ponee.io@tez.apache.org Mon Jan 25 02:37:11 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id B734718064D for ; Mon, 25 Jan 2021 03:37:11 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 654006469D for ; Mon, 25 Jan 2021 02:37:05 +0000 (UTC) Received: (qmail 10970 invoked by uid 500); 25 Jan 2021 02:37:03 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 10890 invoked by uid 99); 25 Jan 2021 02:37:03 -0000 Received: from mailrelay1-he-de.apache.org (HELO mailrelay1-he-de.apache.org) (116.203.21.61) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jan 2021 02:37:03 +0000 Received: from jira2-he-de.apache.org (unknown [IPv6:2a01:4f8:242:1f49::2]) by mailrelay1-he-de.apache.org (ASF Mail Server at mailrelay1-he-de.apache.org) with ESMTPS id BD8683E986 for ; Mon, 25 Jan 2021 02:37:01 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 43544C80816 for ; Mon, 25 Jan 2021 02:37:01 +0000 (UTC) Date: Mon, 25 Jan 2021 02:37:01 +0000 (UTC) From: "David Mollitor (Jira)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (TEZ-4270) HeartbeatHandlerBase Does Not Need Stop Condition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 David Mollitor created TEZ-4270: ----------------------------------- Summary: HeartbeatHandlerBase Does Not Need Stop Condition Key: TEZ-4270 URL: https://issues.apache.org/jira/browse/TEZ-4270 Project: Apache Tez Issue Type: Improvement Reporter: David Mollitor Currently, the code checks if the thread is interrupted or if some {{stop}} variable is set. It does not need to do both. Interrupting a thread is the way to trigger it to stop, no need to add two ways of stopping it. This is especially useful because the thread is a protected variable and can be interrupted from inheriting classes which may not know about this {{stop}} variable. -- This message was sent by Atlassian Jira (v8.3.4#803005)