tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tez CI (Jira)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-4275) Use Google Guava Intern Facility
Date Thu, 28 Jan 2021 22:36:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274032#comment-17274032
] 

Tez CI commented on TEZ-4275:
-----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m 33s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  0s{color} |
{color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  4m 50s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 27s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  2s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 15s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 12s{color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  1m 29s{color} | {color:blue}
Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 39s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  9s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 42s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 39s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 39s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m  8s{color}
| {color:green} tez-common: The patch generated 0 new + 25 unchanged - 1 fixed = 25 total
(was 26) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 16s{color}
| {color:orange} tez-dag: The patch generated 2 new + 54 unchanged - 0 fixed = 56 total (was
54) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 31s{color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 18s{color} | {color:red}
tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 30s{color} | {color:green}
tez-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 11s{color} | {color:green}
tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 21s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 19s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-dag |
|  |  org.apache.tez.dag.app.DAGAppMaster.handle(DAGAppMasterEvent) forces garbage collection;
extremely dubious except in benchmarking code  At DAGAppMaster.java:dubious except in benchmarking
code  At DAGAppMaster.java:[line 874] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-95/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/tez/pull/95 |
| JIRA Issue | TEZ-4275 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
|
| uname | Linux a4408cc799e6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 0d3b428ec |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-95/1/artifact/out/diff-checkstyle-tez-dag.txt
|
| findbugs | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-95/1/artifact/out/new-findbugs-tez-dag.html
|
|  Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-95/1/testReport/
|
| Max. process+thread count | 224 (vs. ulimit of 5500) |
| modules | C: tez-common tez-dag U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-95/1/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Use Google Guava Intern Facility
> --------------------------------
>
>                 Key: TEZ-4275
>                 URL: https://issues.apache.org/jira/browse/TEZ-4275
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Google Guava has a pretty cool Interner facility.
>  
>  * More memory efficient than current offering.  Map contains a weak key and a static
dummy value (current implementation uses a weak value)
>  * Current implementation has a single lock around the entire data structure.  Google
segments their data structure into (default: 4) segments for better concurrency
>  * All the other thoughtful stuff Google has added into this feature



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message