tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shashanka Balakuntala Srinivasa (Jira)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-138) Merge DAG/DAGImpl, Vertex/VertexImpl, Task/TaskImpl, TaskAttempt/TaskAttemptImpl
Date Tue, 19 Jan 2021 07:09:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267701#comment-17267701
] 

Shashanka Balakuntala Srinivasa commented on TEZ-138:
-----------------------------------------------------

Hi [~bikassaha], created a patch where i have merged these classes, let me know if this looks
good.

> Merge DAG/DAGImpl, Vertex/VertexImpl, Task/TaskImpl, TaskAttempt/TaskAttemptImpl
> --------------------------------------------------------------------------------
>
>                 Key: TEZ-138
>                 URL: https://issues.apache.org/jira/browse/TEZ-138
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Priority: Major
>         Attachments: TEZ-138.patch
>
>
> We are not going to have another impl of these interfaces. What are they buying us other
than overhead of overriding every new public method.
> For tests, every class and every methods can be overridden and mocked.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message