From issues-return-39613-archive-asf-public=cust-asf.ponee.io@tez.apache.org Mon Aug 20 22:51:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C0A04180663 for ; Mon, 20 Aug 2018 22:51:03 +0200 (CEST) Received: (qmail 49594 invoked by uid 500); 20 Aug 2018 20:51:02 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 49585 invoked by uid 99); 20 Aug 2018 20:51:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Aug 2018 20:51:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 85CD61801AF for ; Mon, 20 Aug 2018 20:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zofmpKQ_8FfJ for ; Mon, 20 Aug 2018 20:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3822C5F3F0 for ; Mon, 20 Aug 2018 20:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A6145E0D9F for ; Mon, 20 Aug 2018 20:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 15A8F23F98 for ; Mon, 20 Aug 2018 20:51:00 +0000 (UTC) Date: Mon, 20 Aug 2018 20:51:00 +0000 (UTC) From: "TezQA (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-3969) TaskAttemptImpl: static fields initialized in instance ctor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586496#comment-16586496 ] TezQA commented on TEZ-3969: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12936312/TEZ-3969.1.patch against master revision 4b9a7be. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 3.0.1) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : org.apache.tez.dag.app.dag.impl.TestTaskAttempt Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2896//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2896//console This message is automatically generated. > TaskAttemptImpl: static fields initialized in instance ctor > ----------------------------------------------------------- > > Key: TEZ-3969 > URL: https://issues.apache.org/jira/browse/TEZ-3969 > Project: Apache Tez > Issue Type: Bug > Reporter: Gopal V > Assignee: Jaume M > Priority: Minor > Attachments: TEZ-3969.1.patch > > > The TODO is probably well-placed (& the bug looks somewhat intentional to minimize the size of TaskAttemptImpl object). > This isn't causing any bugs at the moment, because the block is called from the same thread always. > {code} > public TaskAttemptImpl(TezTaskAttemptID attemptId, EventHandler eventHandler, > ... > // TODO: Move these configs over to Vertex.VertexConfig > MAX_ALLOWED_OUTPUT_FAILURES = conf.getInt(TezConfiguration > .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES, TezConfiguration > .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_DEFAULT); > MAX_ALLOWED_OUTPUT_FAILURES_FRACTION = conf.getDouble(TezConfiguration > .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION, TezConfiguration > .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION_DEFAULT); > > MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC = conf.getInt( > TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC, > TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC_DEFAULT); > {code} > But these fields are static members of the class & this is excluded in the findbugs to avoid warnings. > {code} > private static double MAX_ALLOWED_OUTPUT_FAILURES_FRACTION; > private static int MAX_ALLOWED_OUTPUT_FAILURES; > private static int MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)