tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TezQA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3985) Correctness: Throw a clear exception for DMEs sent during cleanup
Date Tue, 28 Aug 2018 01:50:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594396#comment-16594396
] 

TezQA commented on TEZ-3985:
----------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12937355/TEZ-3985.1.patch
  against master revision 261bbdd.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2900//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2900//console

This message is automatically generated.


> Correctness: Throw a clear exception for DMEs sent during cleanup
> -----------------------------------------------------------------
>
>                 Key: TEZ-3985
>                 URL: https://issues.apache.org/jira/browse/TEZ-3985
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3985.1.patch
>
>
> If a DME is sent during cleanup, that implies that the .close() of the LogicalIOProcessorRuntimeTask
did not succeed and therefore these events are an error condition.
> These events should not be sent and more importantly should be received by the AM.
> Throw a clear exception, in case of this & allow the developers to locate the extraneous
event from the backtrace.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message