tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TezQA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3969) TaskAttemptImpl: static fields initialized in instance ctor
Date Mon, 20 Aug 2018 20:51:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586496#comment-16586496
] 

TezQA commented on TEZ-3969:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12936312/TEZ-3969.1.patch
  against master revision 4b9a7be.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
                   org.apache.tez.dag.app.dag.impl.TestTaskAttempt

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2896//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2896//console

This message is automatically generated.


> TaskAttemptImpl: static fields initialized in instance ctor
> -----------------------------------------------------------
>
>                 Key: TEZ-3969
>                 URL: https://issues.apache.org/jira/browse/TEZ-3969
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Jaume M
>            Priority: Minor
>         Attachments: TEZ-3969.1.patch
>
>
> The TODO is probably well-placed (& the bug looks somewhat intentional to minimize
the size of TaskAttemptImpl object).
> This isn't causing any bugs at the moment, because the block is called from the same
thread always.
> {code}
> public TaskAttemptImpl(TezTaskAttemptID attemptId, EventHandler eventHandler,
>  ...
>     // TODO: Move these configs over to Vertex.VertexConfig
>     MAX_ALLOWED_OUTPUT_FAILURES = conf.getInt(TezConfiguration
>         .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES, TezConfiguration
>         .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_DEFAULT);
>     MAX_ALLOWED_OUTPUT_FAILURES_FRACTION = conf.getDouble(TezConfiguration
>         .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION, TezConfiguration
>         .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION_DEFAULT);
>     
>     MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC = conf.getInt(
>         TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC,
>         TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC_DEFAULT);
> {code}
> But these fields are static members of the class & this is excluded in the findbugs
to avoid warnings.
> {code}
>   private static double MAX_ALLOWED_OUTPUT_FAILURES_FRACTION;
>   private static int MAX_ALLOWED_OUTPUT_FAILURES;
>   private static int MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message