tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacob Tolar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-3849) Combiner+PipelinedSorter silently drops records
Date Sat, 14 Oct 2017 03:13:00 GMT

    [ https://issues.apache.org/jira/browse/TEZ-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204445#comment-16204445
] 

Jacob Tolar commented on TEZ-3849:
----------------------------------

[~kshukla] see latest patch or updated PR.

Unfortunately PartitionFilter can't easily be updated to call hasNext() on the iterator it
wraps, so I had to add a kludgy peekPartition method to PartitionedRawKeyValueIterator.

> Combiner+PipelinedSorter silently drops records
> -----------------------------------------------
>
>                 Key: TEZ-3849
>                 URL: https://issues.apache.org/jira/browse/TEZ-3849
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jacob Tolar
>            Assignee: Jacob Tolar
>         Attachments: TEZ-3849.1.patch, TEZ-3849.2.patch, TEZ-3849.3.patch
>
>
> This bug was introduced in https://github.com/apache/tez/commit/a47e8fcbea5eeab5a7cf812271d329524cc02dba?diff=split

> when combiner != null, the change in this commit passes kvIter with next() having already
been called. This ends up (silently) dropping the first record in the partition. 
> Will submit PR and attach patch. [~jeagles], not sure if this is the way you want to
fix or not but it does fix my tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message