Mailing-List: contact issues-help@tez.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tez.apache.org
Date: Tue, 6 Sep 2016 20:46:21 +0000 (UTC)
From: "Hitesh Shah (JIRA)" <jira@apache.org>
To: issues@tez.apache.org
Message-ID: <JIRA.13002166.1472760806000.501120.1473194781188@Atlassian.JIRA>
In-Reply-To: <JIRA.13002166.1472760806000@Atlassian.JIRA>
References: <JIRA.13002166.1472760806000@Atlassian.JIRA> <JIRA.13002166.1472760806935@arcas>
Subject: [jira] [Commented] (TEZ-3426) Second AM attempt launched for
 session mode and recovery disabled for certain cases
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 06 Sep 2016 20:46:22 -0000


    [ https://issues.apache.org/jira/browse/TEZ-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468513#comment-15468513 ] 

Hitesh Shah commented on TEZ-3426:
----------------------------------

+1

> Second AM attempt launched for session mode and recovery disabled for certain cases
> -----------------------------------------------------------------------------------
>
>                 Key: TEZ-3426
>                 URL: https://issues.apache.org/jira/browse/TEZ-3426
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Jason Lowe
>            Priority: Critical
>         Attachments: TEZ-3426.001.patch, TEZ-3426.002.patch, TEZ-3426.003.patch, TEZ-3426.004.patch
>
>
> ApplicationSubmissionContext#setMaxAppAttempts does not fully guarantee that there will be only that many attempts at maximum. There are a few exceptional cases that are not count. Tez should protect itself from accidentally starting the second attempt in session mode and when recovery is disabled since the second attempt will always succeed with no work to do.
> {code}
>   @Override
>   public boolean shouldCountTowardsMaxAttemptRetry() {
>     try {
>       this.readLock.lock();
>       int exitStatus = getAMContainerExitStatus();
>       return !(exitStatus == ContainerExitStatus.PREEMPTED
>           || exitStatus == ContainerExitStatus.ABORTED
>           || exitStatus == ContainerExitStatus.DISKS_FAILED
>           || exitStatus == ContainerExitStatus.KILLED_BY_RESOURCEMANAGER);
>     } finally {
>       this.readLock.unlock();
>     }
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)